CI: Rework the test states #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
ci-rework
branch
2 times, most recently
from
bb4a70d to
0a66e61
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 63.53% 63.54%
=======================================
Files 117 117
Lines 12645 12645
=======================================
+ Hits 8034 8035 +1
+ Misses 4611 4610 -1 ☔ View full report in Codecov by Sentry. |
Neither of these should have been feature flags, as they gate breaking changes to the Zcash consensus rules (and in some ways are incompatible with each other), while feature flags should be additive.
nuttycom
reviewed
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.