Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Update to make use of orchard::note::Rho #1264

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0c5a365

@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.26%. Comparing base (3dcac7a) to head (0c5a365).

Files Patch % Lines
zcash_client_sqlite/src/testing.rs 0.00% 7 Missing ⚠️
zcash_client_backend/src/scanning.rs 0.00% 2 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
+ Coverage   63.22%   63.26%   +0.04%     
==========================================
  Files         121      121              
  Lines       13519    13509      -10     
==========================================
  Hits         8547     8547              
+ Misses       4972     4962      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom merged commit a788fc9 into zcash:main Mar 13, 2024
21 of 25 checks passed
@nuttycom nuttycom deleted the orchard_rho branch March 13, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants