Distinguish seed relevance when no derived accounts are present #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
zcs-distinguish-seed-relevance-with-no-accounts
branch
from
860e286 to
03f072c
Compare
str4d
commented
Mar 19, 2024
str4d
force-pushed
the
zcs-distinguish-seed-relevance-with-no-accounts
branch
from
03f072c to
adaa2b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
+ Coverage 63.46% 63.48% +0.02%
==========================================
Files 121 121
Lines 13890 13904 +14
==========================================
+ Hits 8815 8827 +12
- Misses 5075 5077 +2 ☔ View full report in Codecov by Sentry. |
13 tasks
nuttycom
reviewed
Mar 19, 2024
str4d
force-pushed
the
zcs-distinguish-seed-relevance-with-no-accounts
branch
from
adaa2b5 to
cbfc3b8
Compare
|
Force-pushed to address comments from review and a subsequent pairing. |
nuttycom
previously approved these changes
Mar 19, 2024
During wallet migration in particular, the absence of _any_ accounts is expected, and all seeds should be treated as relevant (because accounts cannot be added before a wallet is initialized).
str4d
force-pushed
the
zcs-distinguish-seed-relevance-with-no-accounts
branch
from
cbfc3b8 to
3c1e82a
Compare
|
Force-pushed to address second review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During wallet migration in particular, the absence of any accounts is expected, and all seeds should be treated as relevant (because accounts cannot be added before a wallet is initialized).