Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Fix scan_complete tests. #1289

Merged
merged 1 commit into from
Mar 19, 2024
Merged

zcash_client_sqlite: Fix scan_complete tests. #1289

merged 1 commit into from
Mar 19, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom force-pushed the sqlite_wallet/branching_chain_test_fixes branch from 433c416 to de07e4e Compare March 19, 2024 18:37
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 63.60%. Comparing base (35a60ab) to head (4f7c5bd).
Report is 2 commits behind head on main.

Files Patch % Lines
zcash_client_backend/src/proto.rs 0.00% 7 Missing ⚠️
zcash_client_sqlite/src/testing.rs 92.30% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
+ Coverage   63.48%   63.60%   +0.12%     
==========================================
  Files         121      121              
  Lines       13904    13943      +39     
==========================================
+ Hits         8827     8869      +42     
+ Misses       5077     5074       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom force-pushed the sqlite_wallet/branching_chain_test_fixes branch from de07e4e to 0d4a300 Compare March 19, 2024 20:48
str4d
str4d requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 0d4a300.

zcash_client_sqlite/src/testing/pool.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/data_api/chain.rs Show resolved Hide resolved
zcash_client_backend/src/proto.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Show resolved Hide resolved
zcash_client_sqlite/src/testing.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the sqlite_wallet/branching_chain_test_fixes branch from 0d4a300 to 4f7c5bd Compare March 19, 2024 22:14
@nuttycom
Copy link
Contributor Author

force-pushed to address review comments.

str4d
str4d approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 4f7c5bd

@str4d str4d merged commit 97651a6 into zcash:main Mar 19, 2024
22 of 25 checks passed
@nuttycom nuttycom deleted the sqlite_wallet/branching_chain_test_fixes branch March 19, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuttycom @str4d