Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Fix tests that broke with the addition of Orchard UA receivers. #1301

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nuttycom
Copy link
Contributor

These tests were broken by #1291

str4d
str4d previously approved these changes Mar 22, 2024
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 72c346c

@nuttycom nuttycom force-pushed the fix/orchard_ua_receiver_tests branch from 72c346c to 6f1e4af Compare March 22, 2024 03:15
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (cb218ad) to head (6f1e4af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files         121      121           
  Lines       13985    13985           
=======================================
  Hits         8915     8915           
  Misses       5070     5070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK 6f1e4af with question.

zcash_client_sqlite/src/wallet/init.rs Show resolved Hide resolved
@nuttycom nuttycom merged commit c45d3ae into zcash:main Mar 22, 2024
22 of 25 checks passed
@nuttycom nuttycom deleted the fix/orchard_ua_receiver_tests branch March 22, 2024 04:29
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK 6f1e4af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants