Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Migrate to tonic 0.12 with http 1 #1446

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jul 11, 2024

No description provided.

@str4d
Copy link
Contributor Author

str4d commented Jul 11, 2024

This conflicts with #1422 (in dependency updates), and it would be better to merge this PR before #1422.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.22%. Comparing base (34cf6d2) to head (270eec2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   63.22%   63.22%           
=======================================
  Files         128      128           
  Lines       14865    14865           
=======================================
  Hits         9398     9398           
  Misses       5467     5467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d
Copy link
Contributor Author

str4d commented Jul 11, 2024

Build is failing on WASM because somewhere in the dependency changes, tokio is getting more feature flags enabled (possibly the default features). I'm trying to figure out what is causing this.

@str4d
Copy link
Contributor Author

str4d commented Jul 12, 2024

The WASM build failure is due to hyperium/tonic#1783. In the interim, I've disabled the feature flag in CI.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 270eec2

@nuttycom nuttycom merged commit 73d0c5b into main Jul 15, 2024
28 checks passed
@nuttycom nuttycom deleted the tonic-0.12 branch July 15, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants