Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty zcash_note_encryption crate #357

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Mar 19, 2021

The general note encryption logic shared between Sapling and Orchard will be moved into here.

@str4d str4d added this to the Core Sprint 2021-10 milestone Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #357 (b7c31e3) into master (3a8e729) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   64.64%   64.58%   -0.06%     
==========================================
  Files          69       70       +1     
  Lines        7079     7082       +3     
==========================================
- Hits         4576     4574       -2     
- Misses       2503     2508       +5     
Impacted Files Coverage Δ
components/zcash_note_encryption/src/lib.rs 0.00% <0.00%> (ø)
zcash_primitives/src/block.rs 45.16% <0.00%> (-1.62%) ⬇️
zcash_primitives/src/legacy.rs 60.81% <0.00%> (-0.84%) ⬇️
zcash_primitives/src/transaction/mod.rs 48.86% <0.00%> (-0.38%) ⬇️
zcash_primitives/src/note_encryption.rs 76.17% <0.00%> (ø)
zcash_proofs/src/circuit/sprout/input.rs 0.00% <0.00%> (ø)
zcash_primitives/src/transaction/components.rs 50.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8e729...b7c31e3. Read the comment docs.

@nuttycom
Copy link
Contributor

Incorporated into #358

@nuttycom nuttycom closed this Mar 26, 2021
@str4d str4d reopened this Mar 27, 2021
@str4d
Copy link
Contributor Author

str4d commented Mar 27, 2021

I prefer to merge this PR and then migrate the logic in a separate PR.

@str4d str4d merged commit 6fa9019 into zcash:master Mar 27, 2021
@str4d str4d deleted the zcash_note_encryption branch March 27, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants