Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZIP-254] Deployment of the NU7 Network Upgrade #928

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[ZIP-254] Deployment of the NU7 Network Upgrade #928

merged 3 commits into from
Nov 6, 2024

Conversation

arya2
Copy link
Collaborator

@arya2 arya2 commented Nov 1, 2024 •
edited
Loading

Part of #839.

@arya2 arya2 mentioned this pull request Nov 1, 2024
Open
@nuttycom nuttycom added NU7 proposal consensus Consensus changes, and errors or omissions in consensus specification labels Nov 1, 2024
@arya2 arya2 marked this pull request as draft November 1, 2024 19:09
nuttycom
nuttycom previously requested changes Nov 1, 2024
View reviewed changes
zips/draft-nu7-deployment.md Outdated Show resolved Hide resolved
@arya2 arya2 changed the title Add draft-nu7-deployment [ZIP-254] Add draft-nu7-deployment Nov 1, 2024
@arya2 arya2 force-pushed the draft-nu7-deployment branch from 768377d to ffd593b Compare November 1, 2024 21:52
@arya2 arya2 marked this pull request as ready for review November 4, 2024 19:50
daira
daira reviewed Nov 4, 2024
View reviewed changes
zips/draft-nu7-deployment.md Outdated Show resolved Hide resolved
daira
daira approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. The actual changes to be deployed can be added later.

@arya2 arya2 force-pushed the draft-nu7-deployment branch from ffd593b to ce27ddf Compare November 4, 2024 20:01
@arya2 arya2 dismissed nuttycom’s stale review November 4, 2024 20:03

Removed references to NU7 ZIP candidates from draft

@daira daira changed the title [ZIP-254] Add draft-nu7-deployment [ZIP-254] Deployment of the NU7 Network Upgrade Nov 5, 2024
daira
daira reviewed Nov 5, 2024
View reviewed changes
zips/zip-0254.md Outdated Show resolved Hide resolved
daira
daira approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo correcting the protocol spec reference.

daira
daira approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Automated Release Test and others added 3 commits November 5, 2024 17:02
@nuttycom nuttycom force-pushed the draft-nu7-deployment branch from fbd861e to ee0214e Compare November 6, 2024 00:03
str4d
str4d approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for merging as draft ZIP

nuttycom
nuttycom approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@str4d str4d merged commit 6025d32 into main Nov 6, 2024
@str4d str4d deleted the draft-nu7-deployment branch November 6, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

@daira daira daira approved these changes

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
consensus Consensus changes, and errors or omissions in consensus specification NU7 proposal ZIP number assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arya2 @nuttycom @daira @str4d