Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure, make, cmake, and build ices #613

Merged

Conversation

vladdoster
Copy link
Member

  • 'configure' and 'make' ices refactored
  • new 'build' ice sets 'configure' and 'make ices if no flags are needed.
  • new 'cmake' ice will build/install using 'cmake'
  • Delete command now handles programs using 'make' and 'cmake' ices
  • zunit tests added
  • Setting ZINIT[DEBUG] enables debug logging (i.e., +zi-log "{dbg} message ...")

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster
Copy link
Member Author

The recipe for cmatrix command:

zinit for \
    as'program' \
    atclone"autoreconf -ifm; ./configure --prefix=$ZPFX" \
    atpull'%atclone' \
    make"-j PREFIX=$ZPFX install" \
    pick"cmatrix" \
  abishekvashok/cmatrix

is simplified to either:

zinit build for abishekvashok/matrix

or

zinit configure make for abishekvashok/matrix

@vladdoster vladdoster force-pushed the refactor/make-ices branch 2 times, most recently from 50f812c to cd08e34 Compare December 24, 2023 23:36
@vladdoster vladdoster changed the base branch from main to refactor/make-ices December 30, 2023 01:14
vladdoster and others added 6 commits December 29, 2023 19:15
- 'configure' and 'make' ices refactored
- Delete command now handles programs using 'make' and 'cmake' ices
- Setting `ZINIT[DEBUG]` enables debug logging (i.e., `+zi-log "{dbg}
- New 'build' ice sets 'configure' and 'make ices if no flags are needed.
- New 'cmake' ice will build/install using 'cmake'
- Zunit tests added

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@github-actions github-actions bot removed the release label Dec 30, 2023
@vladdoster vladdoster merged commit 70d63bb into zdharma-continuum:refactor/make-ices Dec 30, 2023
1 check passed
vladdoster added a commit that referenced this pull request Jan 9, 2024
* Refactored 'configure' and 'make' ices
* New 'build' ice sets 'configure' and 'make ices if no flags are needed.
* New 'cmake' ice will build/install using 'cmake'
* Delete command now handles programs using 'make' and 'cmake' ices
* Setting `$ZINIT[DEBUG]` enables debug logging (i.e., `+zi-log "{dbg} message ..."`)
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
# [3.13.0](v3.12.1...v3.13.0) (2024-01-18)

### Bug Fixes

* **ci:** remove duplicate gh-r  zunit job ([#623](#623)) ([70cefc0](70cefc0))
* debug logging logic and format ([#592](#592)) ([3c7e5be](3c7e5be))
* handle zinit --help ([#597](#597)) ([8cf9104](8cf9104))
* link ice check in .zinit-download-snippet function ([#608](#608)) ([358ef03](358ef03))
* pin dua gh-r test to v2.20.3 ([#605](#605)) ([0ba778a](0ba778a))
* silence unzip command in ziextract ([#614](#614)) ([71764bf](71764bf))
* tar permissions when `ziextract` ran as root user ([#557](#557)) ([e2d477c](e2d477c))
* update labeler config to v5 ([#604](#604)) ([794723c](794723c))

### Features

* configure, make, cmake, and build ices ([#613](#613)) ([#616](#616)) ([22e66db](22e66db))
* **delete:** fix unsetting plugin state & add `--debug` / `--quiet` flags ([#622](#622)) ([3f4b685](3f4b685))
* remove zpextract and use ziextract ([#611](#611)) ([2ccac85](2ccac85))
@vladdoster vladdoster self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant