Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEA-4316: Disable caching dependencies by default in Node.js #388

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Nov 21, 2024

Description (required)

  • chore(planner/nodejs): Clean up apt lists after installing dependencies
  • fix(planner/nodejs): Disable caching dependencies by default
  • chore: Update dependencies

Related issues & labels (optional)

  • Closes ZEA-4316
  • Suggested label: enhancement

Disable cache_dependencies by default now due to some known cases:

* Monorepos: the critical dependencies are usually in the subdirectories.
* Some postinstall scripts may require some files (other than package.json and
  lockfiles in the root)
* Customized installation command
* app root != project root (which means, there is more than 1 apps in this project)

Considering we do not cache the Docker layer, let's disable it by default.
@pan93412 pan93412 self-assigned this Nov 21, 2024
@yuaanlin yuaanlin merged commit 2f6a009 into main Nov 21, 2024
5 checks passed
@yuaanlin yuaanlin deleted the pan93412/zea-4316-disable-cache_dependencies-by-default-in-zbpack branch November 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants