Update Fork... #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Code generate support for IDataLoader *Make TextLoader API code generated so that it's at functional parity with the text loader in the ML.Net infrastructure. *Move TextLoader API under Microsoft.ML.Data namespace *Add convenience TextLoader API. *Add error checking for invalid loader arguments such as ordinal, column names. *Update baselines. *Update samples with new loader API and backward compatibility with old loader API.
* added ceiling to mathutils and have parquetloader default to sequential reading instead of throwing * factor out sequence creation and add check for overflow in MathUtils
…ph variable outputs (#152) * Adding support for training metrics in PipelineSweeperMacro and needed support files. Also includes new output information in PipelineSweeperMacro output graph to make consumption of returned pipelines easier. * Changed where XML comment was placed. * Added more tests (uncommented and fixed) for auto inference. Changed magic number in AutoMlUtils to be mix double value, per review comment. * Added another test, TestPipelineSweeperMacroNoTransforms. * Updated tests to include warning disabling (following Zeeshan S's example) to get build working. * Changes to checks in AutoMlUtils (more correct usage of them). * Fixing issue with ExceptParam using value and not name of parameters. * Fixing errors on use of ExceptParam.
* Reduce number of hash bits in stratification column and add a unit test. * Address PR comments.
zeahmed
pushed a commit
that referenced
this pull request
Jan 3, 2019
* Added placeholder * Cleaned up Infos (replaced with ColumnPairs) * Added ColumnInfo * Added all the Create() methods. * Added Mapper * Commented out the EntryPoint * Added PcaEstimator2 * PcaWorkout test passes * Added pigsty api * Fixed EntryPoint * Fixed the arguments * Fixed tests and added pigsty test * Deleted Wrapped PCA transform * Float -> float * Cleaned docstrings * Removed some unnecessary checks * Simplified unnecessary code * Moved some fields to ColumnInfo for simplifications * Simplified weight columns * Address PR comments #1 * Addressed PR comments #2 * Moved the static test * PR comments #3 * Moved schema related information out of ColumnInfo and into Mapper.ColumnSchemaInfo. * PR comments * PR comments * Updated manifest for entrypoint PcaCalculator * Fixed schema exceptions
zeahmed
pushed a commit
that referenced
this pull request
Jan 3, 2019
* Implement VBuffer master plan WIP #1 * Getting everything to build and tests passing * Keep moving to the master plan of VBuffer. * Remove the rest of the VBuffer.Count usages in ML.Data * Remove the rest of the VBuffer.Count usages and make VBuffer.Count private. * Fix two failing tests. * Fix FastTreeBinaryClassificationCategoricalSplitTest by remembering the underlying arrays in the column buffer in Transposer. Also enable a Transposer test, since it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.