Skip to content

Commit

Permalink
fix(assets): update AppStream ID to org.zealdocs.zeal
Browse files Browse the repository at this point in the history
AppStream specification strongly encourages lowercase ID.
Flatpak documentation recommends to avoid .desktop suffix in the ID.
  • Loading branch information
trollixx committed Jan 24, 2021
1 parent 5d0f3fb commit d4d7d35
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ squashfs-root/
.vscode/

# Linux appdata
/assets/freedesktop/org.zealdocs.Zeal.appdata.xml
/assets/freedesktop/org.zealdocs.zeal.appdata.xml
10 changes: 5 additions & 5 deletions assets/freedesktop/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ if(UNIX AND NOT APPLE)
DESTINATION ${KDE_INSTALL_ICONDIR}
)

configure_file(
org.zealdocs.Zeal.appdata.xml.in
org.zealdocs.Zeal.appdata.xml
configure_file(
org.zealdocs.zeal.appdata.xml.in
org.zealdocs.zeal.appdata.xml
)

install(FILES ${CMAKE_BINARY_DIR}/assets/freedesktop/org.zealdocs.Zeal.appdata.xml
install(FILES ${CMAKE_BINARY_DIR}/assets/freedesktop/org.zealdocs.zeal.appdata.xml
DESTINATION ${KDE_INSTALL_METAINFODIR}
)

install(FILES "org.zealdocs.Zeal.desktop"
install(FILES "org.zealdocs.zeal.desktop"
DESTINATION ${KDE_INSTALL_APPDIR}
)
endif()
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop">
<id>org.zealdocs.Zeal</id>
<id>org.zealdocs.zeal</id>
<name>Zeal</name>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-3.0-or-later</project_license>
Expand Down
2 changes: 1 addition & 1 deletion pkg/appimage/appimage-amd64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ AppDir:
path: build.appimage/AppDir

app_info:
id: org.zealdocs.Zeal
id: org.zealdocs.zeal
name: zeal
icon: zeal
version: 0.6.1 # TODO: Use version from CMake.
Expand Down
2 changes: 1 addition & 1 deletion src/app/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ int main(int argc, char *argv[])
}

// Set application-wide window icon. All message boxes and other windows will use it by default.
qapp->setDesktopFileName(QStringLiteral("org.zealdocs.Zeal.desktop"));
qapp->setDesktopFileName(QStringLiteral("org.zealdocs.zeal.desktop"));
qapp->setWindowIcon(QIcon::fromTheme(QStringLiteral("zeal"),
QIcon(QStringLiteral(":/zeal.ico"))));

Expand Down

0 comments on commit d4d7d35

Please sign in to comment.