Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The space is not implementing on device.name #359

Closed
dhreben opened this issue Sep 24, 2024 · 4 comments · Fixed by #370
Closed

The space is not implementing on device.name #359

dhreben opened this issue Sep 24, 2024 · 4 comments · Fixed by #370
Labels
bug Something isn't working
Milestone

Comments

@dhreben
Copy link
Contributor

dhreben commented Sep 24, 2024

The device.name set underscore ignoring the main.yml when a space is inserted

Linked with zebrunner/stf#1022

@dhreben dhreben added the bug Something isn't working label Sep 24, 2024
@dhreben dhreben added this to the 3.0 milestone Sep 24, 2024
vdelendik added a commit that referenced this issue Sep 25, 2024
#359: added support for device naming on Linux with spaces
@vdelendik
Copy link
Contributor

done: #362

@dhreben
Copy link
Contributor Author

dhreben commented Sep 27, 2024

Will be fix after zebrunner/stf#918

@dhreben
Copy link
Contributor Author

dhreben commented Oct 4, 2024

Reopened

Mac case:

Steps:

  1. Open main.yml
  2. Enter iOS device name with space -> iPhone SE
  3. Run ansible script
  4. ./zebrunner.sh start

Actual result: iOS containers are not up. Docker: invalid reference format: repository name must be lowercase.

solvd@idmcloud mcloud-agent % ./zebrunner.sh start

Device with udid: '00008030001C35AE3C42402E' was SUCCESSFULLY detected as connected.
grep: SE-00008..............2402E: No such file or directory
grep: SE-0000................402E: No such file or directory
grep: SE-000................402E: No such file or directory

	Creating '0000.............402E' containers:

wdaIpaPath: /Users/idmcloud/tools/WebDriverAgent.ipa
wdaBundleId: com.facebook.WebDriverAgentRunner.xctrunner

device-iPhone SE-0000...............C42402E-mitm:       docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
already created
device-iPhone SE-00...............42402E-connector:  docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
already created
device-iPhone SE-000.............3C42402E:            docker: invalid reference format: repository name must be lowercase.

@dhreben dhreben reopened this Oct 4, 2024
@azarouski azarouski linked a pull request Oct 4, 2024 that will close this issue
@dhreben
Copy link
Contributor Author

dhreben commented Oct 8, 2024

Fixed according zebrunner/stf#918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants