Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry mouse pointer on Wayland #13258

Open
1 task done
filipwiech opened this issue Jun 19, 2024 · 4 comments · Fixed by #17496
Open
1 task done

Blurry mouse pointer on Wayland #13258

filipwiech opened this issue Jun 19, 2024 · 4 comments · Fixed by #17496
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc

Comments

@filipwiech
Copy link

filipwiech commented Jun 19, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I have the following setup:

  • Ubuntu 24.04 GNOME Wayland
  • Main laptop screen, 100% scaling
  • External 4K monitor, set to 200% scaling

When I move Zed onto the 4K screen, the window is scaled nicely (correct size and crisp graphics), however whenever I move the mouse pointer over the editor it becomes blurry. It has the correct size, but it's as if the icon used for the rendering came from a lower resolution asset. If I move the pointer outside of the Zed window (for example over the desktop or some other application) then it becomes sharp. Sorry for no images, but unfortunately it doesn't show on screenshots.

Environment

Zed: v0.141.0 (Zed Nightly d4891a6)
OS: Linux Wayland ubuntu 24.04
Memory: 31 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
@filipwiech filipwiech added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 19, 2024
@notpeter notpeter added mouse interaction Feedback for mouse interaction states, actions, etc linux and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 19, 2024
@notpeter
Copy link
Member

Can you try the commands shown in #14862 to see if that helps?

@senonide
Copy link
Contributor

senonide commented Aug 17, 2024

Same problem with this setup:

  • Fedora 40 Gnome Wayland
  • Laptop screen 2880x1920p, 200% scaling
  • Zed v0.148.1

Only when I move the mouse pointer over the editor, it becomes blurry. It seems that the problem comes from scaling at 200% because this does not happen when the screen is at a scaling factor of 100%.

Can you try the commands shown in #14862 to see if that helps?

I tried it but it doesn't fix the problem. I am already using the default cursor in Fedora (Adwaita)

@apricotbucket28
Copy link
Contributor

I believe the issue here is that when we set the cursor surface for the pointer we don't actually specify the buffer scale for said wl_surface.
Here's SCTK code for reference: https://github.com/Smithay/client-toolkit/blob/c583de8dd5651f8168c6513cd282137c42aae049/src/seat/pointer/mod.rs#L458-L495

mikayla-maki pushed a commit that referenced this issue Sep 9, 2024
Closes #13258

Release Notes:

- Fixed blurry mouse cursor on wayland when the screen scale is other
than 100%

Before:
![Screenshot from 2024-09-06
14-38-30](https://github.com/user-attachments/assets/e4553503-ecea-4b53-b80d-43732d34fa62)

After:
![Screenshot from 2024-09-06
14-38-56](https://github.com/user-attachments/assets/ce563d3a-2b44-44b9-9f59-f0042609924e)
@mikayla-maki mikayla-maki reopened this Oct 2, 2024
noaccOS pushed a commit to noaccOS/zed that referenced this issue Oct 19, 2024
…es#17496)

Closes zed-industries#13258

Release Notes:

- Fixed blurry mouse cursor on wayland when the screen scale is other
than 100%

Before:
![Screenshot from 2024-09-06
14-38-30](https://github.com/user-attachments/assets/e4553503-ecea-4b53-b80d-43732d34fa62)

After:
![Screenshot from 2024-09-06
14-38-56](https://github.com/user-attachments/assets/ce563d3a-2b44-44b9-9f59-f0042609924e)
@Raiden0456
Copy link

I've just encountered this issue, mouse pointer was definitely fine a week ago. Is this an ongoing issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants