Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: fn key modifier doesn't work anymore #22674

Closed
1 task done
korikhin opened this issue Jan 5, 2025 · 3 comments · Fixed by #23070
Closed
1 task done

macos: fn key modifier doesn't work anymore #22674

korikhin opened this issue Jan 5, 2025 · 3 comments · Fixed by #23070
Labels
bug [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc macOS Platform-specific feedback for macOS behaviors, features, design, etc regression A bug that was introduced in a recent release reproducible Verified steps to reproduce included

Comments

@korikhin
Copy link

korikhin commented Jan 5, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

At some point 🌐F stopped working regardless of the option below.

Screenshot 2025-01-05 at 13 44 46



I've tried to rebind it from

"ctrl-cmd-f": "zed::ToggleFullScreen"

to

"fn-f": "zed::ToggleFullScreen"

and it didn't help, BUT this works

"fn f": "zed::ToggleFullScreen"

So... basically pressing F doesn't affect anything while the Fn key is pressed.

Zed Version and System Specs

Zed: v0.167.1 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

No response

@korikhin korikhin added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 5, 2025
@notpeter notpeter added regression A bug that was introduced in a recent release macOS Platform-specific feedback for macOS behaviors, features, design, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc reproducible Verified steps to reproduce included and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 6, 2025
@notpeter
Copy link
Member

notpeter commented Jan 6, 2025

I can reproduce. fn as a keymap modifier (e.g. fn-f) last worked with Zed v0.163.x and
broke in 0.164.x likely caused by some of the follow-on work for:

Thanks for reporting.

@notpeter notpeter changed the title Fullscreen toggle key binding doesn't work anymore macos: fn key modifier doesn't work anymore Jan 6, 2025
@notpeter
Copy link
Member

notpeter commented Jan 6, 2025

We should probably also add this to the default macOS keybinds:

  {
    "bindings": {
      "fn-f": "zed::ToggleFullScreen"
    }
  }

ConradIrwin added a commit that referenced this issue Jan 13, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2025
Fixes #22674

Release Notes:

- Fixed a bug binding to `fn-X` (where X is a printing key) on macOS
@korikhin
Copy link
Author

We should probably also add this to the default macOS keybinds:

  {
    "bindings": {
      "fn-f": "zed::ToggleFullScreen"
    }
  }

This would be great.

notpeter added a commit that referenced this issue Jan 15, 2025
- See:
#22674 (comment)

Release Notes:

- macos: Added `fn-f` keyboard shortcut for fullscreen toggle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc macOS Platform-specific feedback for macOS behaviors, features, design, etc regression A bug that was introduced in a recent release reproducible Verified steps to reproduce included
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants