Show Icons for Completion Kind

[Feel-ix-343]

Takes influence from the icons here and adds completion kind icons to zed completions. (It looks beautiful!)

• Resolves Code completion icons #4943 (link).

Preview with Rust-Analyzer on the Zed codebase:

[Feel-ix-343]

And a future step could be to make this configurable by Zed themes

[Feel-ix-343]

I will make the icons the same color as the text!

[maxdeviant]

I think it's unlikely we'll merge in this current state, as we would need to design all of these icons to match our current icon set.

[Feel-ix-343]

Okay. Are there plans for themes to configure icons?

[maxdeviant]

Okay. Are there plans for themes to configure icons?

We are planning on adding the ability for extensions to provide icons, but no timeline on it yet. Right now our primary focus with extensions is making sure all of our current language servers can be expressed using the extension API.

Here's the tracking issue for icons in extensions: #8843

[filipwiech]

Maybe this PR could be repurposed and show text with a styled font (muted + colored depending on the completion type) instead of the icons for now? 🤔 Icons could then always be added later and made configurable (maybe the text should be configurable by the user/theme too). 🙂

[maxdeviant]

Maybe this PR could be repurposed and show text with a styled font (muted + colored depending on the completion type) instead of the icons for now? 🤔 Icons could then always be added later and made configurable (maybe the text should be configurable by the user/theme too). 🙂

I think we’re a little pressed for real estate here to be showing words of variable lengths.

[filipwiech]

Maybe this PR could be repurposed and show text with a styled font (muted + colored depending on the completion type) instead of the icons for now? 🤔 Icons could then always be added later and made configurable (maybe the text should be configurable by the user/theme too). 🙂

I think we’re a little pressed for real estate here to be showing words of variable lengths.

That's understandable. 🙂 To be honest I wasn't really thinking about whole words, but more like letters, kind of similar to what for example IntelliJ does (m - method, f - field, v - variable, etc.), but perhaps it would be not clear enough. 👍

[jezikk]

XCode examples:

[Feel-ix-343]

XCode examples:

I like this to - it is technically another icon style though and I think either way the Zed team would want to redesign the icons; It could be quite simple if they are just characters, however.

[maxdeviant]

I'm going to close this for now, as I think we'll want to involve our designer, @/iamnbutler, when he's back from paternity leave to make sure we settle on an approach that aligns with our design direction for Zed.

[Feel-ix-343]

Hey!

@iamnbutler bump (no pressure)

[d1y]

@iamnbutler If you have time, can you take a look at this? ^:)

[retort00]

@iamnbutler bump 🙏