-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Fix canonicalize return UNC path #11083
Merged
mikayla-maki
merged 7 commits into
zed-industries:main
from
CharlesChen0823:fixed_windows_fs_canonicalize
May 7, 2024
Merged
Windows: Fix canonicalize return UNC path #11083
mikayla-maki
merged 7 commits into
zed-industries:main
from
CharlesChen0823:fixed_windows_fs_canonicalize
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Apr 27, 2024
CharlesChen0823
changed the title
Fixed windows fs canonicalize
Windows: Fix canonicalize return UNC path
Apr 27, 2024
|
@CharlesChen0823 is this PR ready to go? The current fix looks a lot better and I'd be down to merge it :) |
@mikayla-maki yes, it's ready for review. |
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows platform, using notify to watch file events.
path.join(file_path)
.abs_path
is not unc path, so we get all file events with not unc path.strip_prefix
unc path all times, it will always print annoy error.@mikayla-maki I can't reopen pre closed pr #10501 .
Release Notes: