Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: Register tasks on Rust side and not via tasks.json #12345

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

osiewicz
Copy link
Contributor

/cc @RemcoSmitsDev new task indicators weren't showing for me in JSON files.
tasks.json of native grammars is not being read by anything by default, so we tend to register tasks as Rust structs, foregoing the deserialization step. This doesn't apply to tasks registered in extensions, which have to have tasks.json.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 27, 2024
@RemcoSmitsDev
Copy link
Contributor

Will have to change my JavaScript as well then.

@osiewicz osiewicz merged commit 345361c into main May 27, 2024
8 checks passed
@osiewicz osiewicz deleted the fix-json-tasks branch May 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants