Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pane removeItem event before removing the item #15541

Conversation

RemcoSmitsDev
Copy link
Contributor

@RemcoSmitsDev RemcoSmitsDev commented Jul 31, 2024

This PR renames and added a new pane event to indicate the difference between removing and removed event. This change is needed for the debugger implementation, if you close a pane we have to send a terminateThread request to the adapter because it's not supported to reopen a pane. So when the pane is removing we have to know what thread it is what is stored on the panel itself, so we have to be able to get this information before the pane is actually removed.

So my idea how to fix this was by adding a new event called RemovedItem which is a rename of RemoveItem which also makes a bit more sense because the item is removed at that point. And seeing the name RemoveItem does not really say that it's removed, more like we are removing the item.

/cc @mikayla-maki

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 31, 2024
@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review July 31, 2024 15:37
@mikayla-maki
Copy link
Contributor

Thank you!

@mikayla-maki mikayla-maki merged commit 3c404de into zed-industries:main Jul 31, 2024
10 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the send-remove-item-event-before-removing-it branch August 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants