Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap terminal commands in single quotation marks instead of backticks #17637

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

bestgopher
Copy link
Contributor

@bestgopher bestgopher commented Sep 10, 2024

before:
image
after:
image

Since I often copy the output commands to run in the command line, using backticks can cause errors because, in shell, backticks mean passing the execution result of the command inside them to the -c option. Therefore, I replace backticks with single quotes here.
image

Release Notes:

  • Fix display of task commands to not use backticks

When printing a command to run, use single quotes instead of backticks,
as backticks mean executing the command rather than treating it as a
string.

Signed-off-by: bestgopher <84328409@qq.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 10, 2024
@maxdeviant maxdeviant changed the title refactor: Use single quotation marks instead of backticks Wrap terminal commands in single quotation marks instead of backticks Sep 10, 2024
@ConradIrwin ConradIrwin merged commit 37b2f4b into zed-industries:main Sep 17, 2024
11 checks passed
@ConradIrwin
Copy link
Member

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants