Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: Add session state indicator to title bar #18645

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

osiewicz
Copy link
Contributor

@osiewicz osiewicz commented Oct 2, 2024

image
The indicator turns yellow when ssh client is trying to reconnect. Note that the state tracking is probably not ideal (we'll see how it pans out once we start dog-fooding), but at the very least "green=good" should be a decent mental model for now.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 2, 2024
@osiewicz osiewicz merged commit 19b1866 into main Oct 2, 2024
9 checks passed
@osiewicz osiewicz deleted the ssh-titlebar-indicator branch October 2, 2024 22:35
SomeoneToIgnore added a commit that referenced this pull request Oct 3, 2024
Follow-up of #18645

Release Notes:

- N/A
schpet added a commit to schpet/zed that referenced this pull request Oct 3, 2024
* upstream/main: (76 commits)
  Remove a debug dev config line (zed-industries#18689)
  Update Rust crate thiserror to v1.0.64 (zed-industries#18677)
  Add command palette action name to outline panel docs (zed-industries#18678)
  Add basic outline panel docs (zed-industries#18674)
  ssh: Add session state indicator to title bar (zed-industries#18645)
  Update Rust crate clap to v4.5.19 (zed-industries#18660)
  Sort dependencies in `Cargo.toml` files (zed-industries#18657)
  collab: Revert changes to Clickhouse event rows (zed-industries#18654)
  Replace isahc with async ureq (zed-industries#18414)
  Update cloudflare/wrangler-action digest to 168bc28 (zed-industries#18651)
  Prepare to sync other kinds of settings (zed-industries#18616)
  editor: Ensure proposed changes editor is syntax-highlighted when opened (zed-industries#18648)
  language: Update buffer doc comments (zed-industries#18646)
  Revert "Fix blurry cursor on Wayland at a scale other than 100%" (zed-industries#18642)
  Tweak warning diagnostic toggle (zed-industries#18637)
  Adjust spacing and sizing of buffer search bar icon buttons (zed-industries#18638)
  docs: Add missing UI font settings to "Configuring Zed" (zed-industries#18267)
  Use `const` over `static` for string literals (zed-industries#18635)
  docs: Add FIPS mode error to Linux troubleshooting (zed-industries#18407)
  v0.157.x dev
  ...
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
![image](https://github.com/user-attachments/assets/0ed6f59c-e0e7-49e6-8db7-f09ec5cdf653)
The indicator turns yellow when ssh client is trying to reconnect. Note
that the state tracking is probably not ideal (we'll see how it pans out
once we start dog-fooding), but at the very least "green=good" should be
a decent mental model for now.

Release Notes:

- N/A
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant