Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: Improve dismissal behaviour #18900

Merged
merged 2 commits into from
Oct 9, 2024
Merged

ssh: Improve dismissal behaviour #18900

merged 2 commits into from
Oct 9, 2024

Conversation

osiewicz
Copy link
Contributor

@osiewicz osiewicz commented Oct 9, 2024

Do not always close current window in SshConnectionModal; only do so when the window was spawned from ssh modal. Assign unique IDs to "Open folder" buttons

Closes #ISSUE

Release Notes:

  • N/A

Do not always close current window in SshConnectionModal; only do so when the window was spawned from ssh modal.
Assign unique IDs to "Open folder" buttons
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 9, 2024
@osiewicz osiewicz merged commit f50bca7 into main Oct 9, 2024
9 checks passed
@osiewicz osiewicz deleted the ssh-dismiss-improvements branch October 9, 2024 10:22
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
Do not always close current window in SshConnectionModal; only do so
when the window was spawned from ssh modal. Assign unique IDs to "Open
folder" buttons

Closes #ISSUE

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant