Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Add support for insert button #19245

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

axelcarl
Copy link
Contributor

This commit adds support for using the physical insert-button. First click toggles insert mode and subsequent clicks toggle back and forth between replace and insert mode.

Closes #19224

Release Notes:

  • Added support for using the insert button for vim_mode.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 15, 2024
@maxdeviant maxdeviant changed the title vim: add support for insert-btn vim: Add support for insert button Oct 15, 2024
@axelcarl axelcarl marked this pull request as draft October 15, 2024 20:35
@axelcarl axelcarl marked this pull request as ready for review October 15, 2024 20:40
This commit adds support for using the physical insert-btn. First
click toggles insert mode and subsequent clicks toggle back and
forth between replace and insert mode.
@axelcarl
Copy link
Contributor Author

Apologies for the first 2 pushes, first time contributing, was a lot easier to solve this problem than what I initially anticipated. :)

@rudolfkastl
Copy link
Contributor

Just built latest stable 0.156.2 with the patch you provided on Linux and tested it! It works! Thank you so much!

@mrnugget mrnugget merged commit a77ec94 into zed-industries:main Oct 16, 2024
10 checks passed
@mrnugget
Copy link
Member

Thank you! (The "wow, that's a way of using Vim I never considered"-surprises never stop 🙂)

@axelcarl axelcarl deleted the vim-insert-btn branch October 16, 2024 10:58
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
This commit adds support for using the physical insert-button. First
click toggles insert mode and subsequent clicks toggle back and forth
between replace and insert mode.

Closes zed-industries#19224

Release Notes:

- Added support for using the insert button for vim_mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the <insert> key on the keyboard to switch between insert and replace mode in vim mode
3 participants