Fix empty keystroke with simulated IME #19414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19181
When the keystroke was empty ("") the
ime_key
was converted fromNone
toSome("")
whenwith_simulated_ime
was called. That was leading to not intentional behavior when an empty keystroke was combined withshift-up
in a keybinding["workspace::SendKeystrokes", "shift-up "]
.By adding a
key.is_empty()
we make sure theime_key
keeps asNone
.This was manually tested.
Release Notes: