Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file icons for Zig, Julia, SCSS, HCL, Nix, and Roc #19529

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

PixelJanitor
Copy link
Contributor

@PixelJanitor PixelJanitor commented Oct 21, 2024

Release Notes:

  • Added file icons for Zig, Julia, SCSS, HCL, Nix, and Roc files.
image

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 21, 2024
@maxdeviant maxdeviant changed the title File icons for gleam, zig, Julia, scss, hcl, nix and roc Add file icons for Gleam, Zig, Julia, SCSS, HCL, Nix and Roc Oct 21, 2024
@TanklesXL
Copy link

I just wanna say that I love that Zed is adding a gleam file icon 💜

I have shared this with the gleam core team so they can give some feedback about how Lucy (gleam's mascot) looks here.

For transparency, i'll quote what I told @JosephTLyons when he first shared the PR in the gleam discord:

I just find it's giving more pentagon energy and less star energy 😆

@lpil
Copy link

lpil commented Oct 21, 2024

Hey! This is cool!

The Gleam one looks cute but on my phone now it looks a bit pointy and seems to curves inwards rather than outwards.

Is it possible to see what it would looks like in the UI?

@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Oct 22, 2024

Hey! This is cool!

The Gleam one looks cute but on my phone now it looks a bit pointy and seems to curves inwards rather than outwards.

Is it possible to see what it would looks like in the UI?

I can compile it and provide screenshots tonight.

Huh, strange. I compiled and icons are not showing up for me - maybe I missed a step.

@lpil
Copy link

lpil commented Oct 22, 2024

Jen in the Gleam discord is working on an icon and I think he'll share it here soon for consideration

@JosephTLyons
Copy link
Collaborator

JosephTLyons commented Oct 22, 2024

If the rest of the icons are good, we could remove gleam from this PR and merge it - @maxbrunsfeld @iamnbutler?

Edit: @george-grec - the intention would be that we would open a new PR for the Gleam icon, and not block the rest of the icons in this PR from being shipped in tomorrow's preview release.

@maxdeviant maxdeviant changed the title Add file icons for Gleam, Zig, Julia, SCSS, HCL, Nix and Roc Add file icons for Zig, Julia, SCSS, HCL, Nix, and Roc Oct 22, 2024
@george-grec
Copy link

@JosephTLyons no worries, I'm just an impatient guy, I appreciate the work!

@JosephTLyons
Copy link
Collaborator

@JosephTLyons no worries, I'm just an impatient guy, I appreciate the work!

We want the Gleam icon in Zed too!

@maxdeviant maxdeviant merged commit efd485c into zed-industries:main Oct 22, 2024
13 checks passed
@PixelJanitor PixelJanitor deleted the more-file-icons branch October 28, 2024 15:41
@okkdev okkdev mentioned this pull request Oct 29, 2024
maxdeviant added a commit that referenced this pull request Oct 29, 2024
I took a shot at creating an icon version of the Gleam logo in response
to #19529

Release Notes:

- Added an icon for Gleam files.


![image](https://github.com/user-attachments/assets/97432ded-342f-4d87-8eb2-dc9145513d8c)

<img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM"
src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
notpeter pushed a commit that referenced this pull request Oct 29, 2024
I took a shot at creating an icon version of the Gleam logo in response
to #19529

Release Notes:

- Added an icon for Gleam files.


![image](https://github.com/user-attachments/assets/97432ded-342f-4d87-8eb2-dc9145513d8c)

<img width="231" alt="Screenshot 2024-10-29 at 9 46 33 AM"
src="https://github.com/user-attachments/assets/c957c98f-3da0-4b92-bc21-2a5adca1daa3">

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants