macOS: Improve deadkeys #20515
Merged
macOS: Improve deadkeys #20515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Have feedback on this plugin? Let's hear it! |
ConradIrwin
force-pushed
the
fix-deadkeys
branch
from
a346773 to
4cecede
Compare
maxbrunsfeld
added a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit 2ea4ede.
maxbrunsfeld
added a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit #20515 I'm reverting for now to fix issues with key bindings on Nightly: * `ctrl-c` and `ctrl-m` are being treated as `ctrl-enter` * `ctrl-[` isn't working in vim mode * there's a delay before `cmd-shift-[` switches tabs w/ vim mode enabled Release Notes: - N/A
ConradIrwin
added a commit
that referenced
this pull request
Nov 13, 2024
Merged
ConradIrwin
added a commit
that referenced
this pull request
Nov 13, 2024
Re-land of #20515 with less brokenness In particular it turns out that for control, the .characters() method returns the control code. This mostly didn't make a difference, except when the control code matched tab/enter/escape (for ctrl-y,ctrl-[/ctrl-c) as we interpreted the key incorrectly. Secondly, we were setting IME key too aggressively. This led to (in vim mode) cmd-shift-{ being interpreted as [, so vim would wait for a second [ before letting you change tab. Release Notes: - N/A
notpeter
pushed a commit
that referenced
this pull request
Nov 13, 2024
Re-land of #20515 with less brokenness In particular it turns out that for control, the .characters() method returns the control code. This mostly didn't make a difference, except when the control code matched tab/enter/escape (for ctrl-y,ctrl-[/ctrl-c) as we interpreted the key incorrectly. Secondly, we were setting IME key too aggressively. This led to (in vim mode) cmd-shift-{ being interpreted as [, so vim would wait for a second [ before letting you change tab. Release Notes: - N/A
mrnugget
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19738
This change refactors how we handle input on macOS to avoid simulating our own IME. This fixes a number of small edge-cases, and also lets us remove a bunch of code that had been added to work around bugs in the previous version.
Release Notes:
""on a Brazillian keyboard, you now get a committed " and a new marked ", as happens in other apps. Also, you can now type cmd-^ on an AZERTY keyboard for indent; and ^ on a QWERTZ keyboard now goes to the beginning of line in vim normal mode, ord i "no requires no space to delete within quotes on Brazilian keyboards (thoughd f " spaceis still required asfrelies on the input handler, not a binding).