Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)" #20809

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)" #20809

merged 1 commit into from
Nov 18, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

Issues found:

  • audio does not work well with various set-ups using USB
  • switching audio during initial join may leave the client with no audio at all
  • audio streaming is done on the main thread, beachballing certain set-ups
  • worse screenshare quality (seems that there's no dynamic scaling anymore, compared to the Swift SDK)

This reverts commit 1235d08.

Release Notes:

  • N/A

@SomeoneToIgnore
Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)"
3cd2d66 
Issues found:

* audio does not work well with various set-ups using USB
* switching audio during initial join may leave the client with no audio at all
* audio streaming is done on the main thread, beachballing certain set-ups
* worse screenshare quality (seems that there's no dynamic scaling anymore, compared to the Swift SDK)

This reverts commit 1235d08.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 18, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Nov 18, 2024
Merged
13 tasks
@WeetHet
Copy link
Contributor

WeetHet commented Nov 18, 2024

Noooo, and just when I thought we would be able to package zed in nixpkgs properly 😭

@SomeoneToIgnore
Copy link
Contributor Author

I have a lot of noooo over this too, so I get the feeling.
We're back on track this month, hopefully.

@SomeoneToIgnore SomeoneToIgnore merged commit d92166f into main Nov 18, 2024
11 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/back-to-swift branch November 18, 2024 09:44
SomeoneToIgnore added a commit that referenced this pull request Nov 18, 2024
@SomeoneToIgnore
Reapply "Use livekit's Rust SDK instead of their swift SDK (#13343)" (#…
72854a6 
…20809)

This reverts commit d92166f.
@niklaskorz niklaskorz mentioned this pull request Nov 18, 2024
Merged
13 tasks
SomeoneToIgnore added a commit that referenced this pull request Nov 19, 2024
@SomeoneToIgnore
Reapply "Use livekit's Rust SDK instead of their swift SDK (#13343)" (#…
be5f0b4 
…20809)

This reverts commit d92166f.
SomeoneToIgnore added a commit that referenced this pull request Nov 19, 2024
@SomeoneToIgnore
Reapply "Use livekit's Rust SDK instead of their swift SDK (#13343)" (#…
46329d6 
…20809)

This reverts commit d92166f.

# Conflicts:
#	Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SomeoneToIgnore @WeetHet