Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-render the menu so often #20914

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Don't re-render the menu so often #20914

merged 1 commit into from
Nov 20, 2024

Conversation

ConradIrwin
Copy link
Member

Closes #20710

Release Notes:

  • Fixes opening the menu when Chinese Pinyin keyboard is in use

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 20, 2024
@ConradIrwin ConradIrwin mentioned this pull request Nov 20, 2024
Closed
1 task
@ConradIrwin
Copy link
Member Author

/cherry-pick v0.163.x

@ConradIrwin
Copy link
Member Author

/cherry-pick v0.162.x

@ConradIrwin ConradIrwin merged commit 1475a70 into main Nov 20, 2024
11 checks passed
@ConradIrwin ConradIrwin deleted the fix-menu-with-chinese branch November 20, 2024 17:27
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ConradIrwin
Don't re-render the menu so often (#20914)
1ba7676 
Closes #20710

Release Notes:

- Fixes opening the menu when Chinese Pinyin keyboard is in use
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 20, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ConradIrwin
Don't re-render the menu so often (#20914)
a97e865 
Closes #20710

Release Notes:

- Fixes opening the menu when Chinese Pinyin keyboard is in use
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 20, 2024
Merged
ConradIrwin added a commit that referenced this pull request Nov 20, 2024
@gcp-cherry-pick-bot @ConradIrwin
Don't re-render the menu so often (cherry-pick #20914) (#20916)
8758f5d 
Cherry-picked Don't re-render the menu so often (#20914)

Closes #20710

Release Notes:

- Fixes opening the menu when Chinese Pinyin keyboard is in use

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
ConradIrwin added a commit that referenced this pull request Nov 20, 2024
@gcp-cherry-pick-bot @ConradIrwin
Don't re-render the menu so often (cherry-pick #20914) (#20915)
31ad658 
Cherry-picked Don't re-render the menu so often (#20914)

Closes #20710

Release Notes:

- Fixes opening the menu when Chinese Pinyin keyboard is in use

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Anthony-Eid pushed a commit to Anthony-Eid/zed that referenced this pull request Nov 22, 2024
@ConradIrwin @Anthony-Eid
Don't re-render the menu so often (zed-industries#20914)
494afa7 
Closes zed-industries#20710

Release Notes:

- Fixes opening the menu when Chinese Pinyin keyboard is in use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macos menu cannot expand, keep flickers
1 participant
@ConradIrwin