Revert "lsp: Parse LSP messages on background thread - again (#23122)" #23301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b3b825.
cla-bot
bot
added
the
cla-signed
osiewicz
added a commit
that referenced
this pull request
Jan 17, 2025
osiewicz
added a commit
that referenced
this pull request
Jan 17, 2025
As @ConradIrwin found out in #23301 the LSP messages could be processed out of order after #23122; this PR makes our approach to event processing a bit more conservative - instead of detaching the parsing task we'll now await them in the main loop. This keeps the benefit of #23122 in that deserialization still happens off the main thread, but some of the performance benefit of #23122 could've been a result of the buggy interaction that Conrad discovered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1b3b825.
When debugging git diffs we found that this introduced a re-ordering of messages sent to the LSP:
With the async approach here, the format request can now arrive before the space changed request.
You can reproduce this with
test_strip_whitespace_and_format_via_lspunder some conditions.Release Notes: