Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rs-notify implementation of fs::watch #9040

Merged
merged 7 commits into from
Mar 9, 2024
Merged

Add rs-notify implementation of fs::watch #9040

merged 7 commits into from
Mar 9, 2024

Conversation

mikayla-maki
Copy link
Contributor

@mikayla-maki mikayla-maki commented Mar 7, 2024 •
edited
Loading

This PR simplifies the Zed file system abstraction and implements Fs::watch for linux and windows.

TODO:

  • Figure out why this fails to initialize the file watchers when we have to initialize the config directory paths, but succeeds on subsequent runs.
  • Fix macOS dependencies on old fsevents::Event crate

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 7, 2024
@mikayla-maki mikayla-maki changed the title Add notify implementation of fs::watch Add rs-notify implementation of fs::watch Mar 7, 2024
@mikayla-maki mikayla-maki self-assigned this Mar 7, 2024
@mikayla-maki mikayla-maki marked this pull request as ready for review March 8, 2024 19:56
@mikayla-maki mikayla-maki merged commit ca696fd into main Mar 9, 2024
9 checks passed
@mikayla-maki mikayla-maki deleted the add-inotify-impl branch March 9, 2024 06:18
@williamdes williamdes mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@mikayla-maki mikayla-maki

Labels
cla-signed The user has signed the Contributor License Agreement linux windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikayla-maki @williamdes