This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Add Go Client CI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed deprecation notice from camunda repo. Removed now invalid parts like gateway protocol generation and docker image build.
megglos
commented
Sep 10, 2024
Sijoma
reviewed
Sep 10, 2024
|
|
||
| # Development | ||
|
|
||
| If we had a gateway-protocol change we need to make sure that we regenerate the protobuf file, which is used by the go client. | ||
| In order to do this please follow [this guide](../../gateway-protocol-impl/README.md). |
There was a problem hiding this comment.
No helper guide anymore for this? Can we still link that somehow?
It's certainly quite useful to have. I think I used it from time to time and still needed support with it.
There was a problem hiding this comment.
There is not setup yet to generate the protocol stub, this will be handled separately see Phase 1 of camunda/camunda#21817
It's also not crucial now as there are no changes planned to the GRPC protocol going forward.
Sijoma
reviewed
Sep 10, 2024
Sijoma
approved these changes
Sep 10, 2024
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI to run on main and PRs.
The following stages are equivalent to their base from camunda/camunda:
go-client(run tests) andgo-lint.The
go-apidiffjob was previously comparing the Go client state to the latest stable branch, I went for protecting from breaking changes on each PR instead. As there are not existing releases on this new repo.Instead of using as freshly built Zeebe image for the integration tests I went for referencing the latest 8.6.0-alpha5 release, also instructing test containers to automatically pull it.
Note: I'm making progress on this repo until we have the community hub repo created see camunda-community-hub/community#159