Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around name clash of bitfield and unit fields on spicy-1.9 #20

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

bbannier
Copy link
Member

No description provided.

@bbannier bbannier self-assigned this Sep 21, 2023
@bbannier bbannier marked this pull request as ready for review September 21, 2023 15:12
@bbannier bbannier requested a review from rsmmr September 21, 2023 15:12
analyzer/asn1.spicy Outdated Show resolved Hide resolved
@bbannier
Copy link
Member Author

I'll wait with merging this. With zeek/spicy#1537 we have a PR open to fix the mentioned issue and might want to wait for this to land in zeek/spicy and zeek/zeek.

@bbannier bbannier requested a review from rsmmr September 25, 2023 09:21
@bbannier
Copy link
Member Author

I'll wait with merging this. With zeek/spicy#1537 we have a PR open to fix the mentioned issue and might want to wait for this to land in zeek/spicy and zeek/zeek.

The analyzer has been reworked to use the modern form on >=spicy-1.9.0.

@bbannier bbannier merged commit 43cd332 into main Sep 25, 2023
3 checks passed
@bbannier bbannier deleted the topic/bbannier/spicy-1.9 branch September 25, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants