Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for ignoring memory limits #111

Merged
merged 2 commits into from
Apr 27, 2019
Merged

allow for ignoring memory limits #111

merged 2 commits into from
Apr 27, 2019

Conversation

sstarcher
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #111 into master will decrease coverage by 0.16%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   79.45%   79.29%   -0.17%     
==========================================
  Files          20       20              
  Lines         959      961       +2     
==========================================
  Hits          762      762              
- Misses        183      185       +2     
  Partials       14       14
Impacted Files Coverage Δ
cmd/kube-score/main.go 0% <0%> (ø) ⬆️
score/container/container.go 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a63458...d0180a2. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 25, 2019 •
edited
Loading

Codecov Report

Merging #111 into master will decrease coverage by 0.22%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   79.52%   79.29%   -0.23%     
==========================================
  Files          21       20       -1     
  Lines         962      961       -1     
==========================================
- Hits          765      762       -3     
- Misses        183      185       +2     
  Partials       14       14
Impacted Files Coverage Δ
cmd/kube-score/main.go 0% <0%> (ø) ⬆️
score/container/container.go 94.11% <100%> (ø) ⬆️
score/probes/probes.go 89.28% <0%> (-0.55%) ⬇️
score/security/security.go 100% <0%> (ø) ⬆️
score/checks/checks.go 97.18% <0%> (ø) ⬆️
cmd/kube-score/cmd_version.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00aacb1...364ffc6. Read the comment docs.

@zegl zegl mentioned this pull request Apr 27, 2019
Closed
@zegl
Copy link
Owner

zegl commented Apr 27, 2019

This PR has a conflict in score/container/container.go, can you rebase and resolve the conflict? Thanks.

zegl
zegl approved these changes Apr 27, 2019
View reviewed changes
Copy link
Owner

@zegl zegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution yet again! 🥇

bors r+

bors bot added a commit that referenced this pull request Apr 27, 2019
@bors @sstarcher
Merge #111
890f6cf 
111: allow for ignoring memory limits r=zegl a=sstarcher

#107

Co-authored-by: Shane Starcher <shanestarcher@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 27, 2019

Build succeeded

@bors bors bot merged commit 364ffc6 into zegl:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zegl zegl zegl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstarcher @zegl