Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prediction-markets tests, I #1265

Merged
merged 22 commits into from
Apr 8, 2024
Merged

Fix prediction-markets tests, I #1265

merged 22 commits into from
Apr 8, 2024

Conversation

maltekliemann
Copy link
Member

@maltekliemann maltekliemann commented Feb 23, 2024

What does it do?

  • Tests admin_move_market_to_resolved with disputed markets.
  • Removes test it_resolves_a_disputed_market involving simple_disputes.
  • Moves it_resolves_a_disputed_court_market to integration tests.
  • Uses more granular origins for testing.
  • Fixes wrong use of origins in benchmarks.
  • Adds missing tests for buy_complete_set.
  • Adds missing tests for create_market.

What important points should reviewers know?

Is there something left for follow-up PRs?

Remove all other TODOs. Doing that in separate PRs to avoid bloating this one.

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@maltekliemann maltekliemann added the s:in-progress The pull requests is currently being worked on label Feb 23, 2024
@maltekliemann maltekliemann self-assigned this Feb 23, 2024
@maltekliemann maltekliemann changed the title Mkl pm tests Fix prediction-markets tests Feb 23, 2024
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Feb 24, 2024
@maltekliemann maltekliemann added this to the v0.5.2 milestone Feb 24, 2024
@maltekliemann maltekliemann changed the title Fix prediction-markets tests Fix prediction-markets tests, I Feb 26, 2024
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Feb 29, 2024
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Apr 5, 2024
sea212
sea212 previously approved these changes Apr 5, 2024
zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Apr 5, 2024
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Apr 5, 2024
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (ff6628c) to head (9e54353).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
+ Coverage   91.78%   91.82%   +0.04%     
==========================================
  Files         190      190              
  Lines       34493    34682     +189     
==========================================
+ Hits        31658    31847     +189     
  Misses       2835     2835              
Flag Coverage Δ
tests 91.82% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
zrml/prediction-markets/src/benchmarks.rs Outdated Show resolved Hide resolved
Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Apr 7, 2024
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Apr 7, 2024
@maltekliemann maltekliemann added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Apr 7, 2024
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Apr 8, 2024
@mergify mergify bot added s:review-needed The pull request requires reviews and removed s:review-needed The pull request requires reviews labels Apr 8, 2024
@mergify mergify bot merged commit 45701a6 into main Apr 8, 2024
14 checks passed
@mergify mergify bot deleted the mkl-pm-tests branch April 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants