Update release checklist #1332
Merged
Update release checklist #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 202 202
Lines 38221 38221
=======================================
Hits 35301 35301
Misses 2920 2920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -24,7 +24,7 @@ The following checks can be performed after we have forked off to the release-ca | |||
|
|
|||
| - [ ] Verify the new migrations complete successfully, and the runtime state is correctly updated for any public (non-private/test) networks. | |||
| - [ ] Verify the SDK is up-to-date with the latest changes. | |||
| - [ ] Push runtime upgrade to local clone of Battery Station and ensure the upgrade is executed without errors. | |||
| - [ ] ~~Push runtime upgrade to local clone of Battery Station and ensure the upgrade is executed without errors.~~ Removed since integration tests do the upgrade tests | |||
There was a problem hiding this comment.
We should replace this with "Run integration tests." then. The way you've changed this, we now still have a box we have to tick every time we go through the checklist.
mergify
bot
added
s:in-progress
Chralt98
added
s:review-needed
maltekliemann
approved these changes
May 6, 2024
maltekliemann
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Just a small correction according to the team lead communication.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References