Remove old migrations and clear pallet storage #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltekliemann
added
s:blocked
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
==========================================
- Coverage 93.26% 93.21% -0.05%
==========================================
Files 133 132 -1
Lines 29721 29360 -361
==========================================
- Hits 27718 27368 -350
+ Misses 2003 1992 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maltekliemann
added
s:review-needed
mergify
bot
added
s:in-progress
maltekliemann
added
s:on-hold
|
This pull request is now in conflicts. Could you fix it @maltekliemann? 🙏 |
mergify
bot
added
s:revision-needed
maltekliemann
added
s:review-needed
mergify
bot
added
s:in-progress
maltekliemann
added
s:review-needed
mergify
bot
added
the
s:in-progress
maltekliemann
added
s:review-needed
Chralt98
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
LGTM. Tested try-runtime on Battery Station to figure out how much weight it took. It was about 2% which is fine. However, couldn't test try-runtime on main-net. Since the storage is different there, we could probably wait, but since all related pallets do not have a major amount of storage values, I think we are fine.
maltekliemann
added
s:accepted
mergify
bot
added
s:review-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes old migrations and clears the storage of all previously removed pallets.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References