Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release v0.5.4 #1358

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Merge release v0.5.4 #1358

merged 3 commits into from
Aug 27, 2024

Conversation

Chralt98
Copy link
Member

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Aug 20, 2024
@Chralt98 Chralt98 self-assigned this Aug 20, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 20, 2024
@Chralt98 Chralt98 marked this pull request as ready for review August 20, 2024 08:56
@Chralt98 Chralt98 requested a review from sea212 as a code owner August 20, 2024 08:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.94505% with 73 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (b046f04) to head (de3172c).

Files Patch % Lines
zrml/swaps/src/weights.rs 37.50% 20 Missing ⚠️
zrml/court/src/weights.rs 78.94% 16 Missing ⚠️
zrml/hybrid-router/src/weights.rs 0.00% 13 Missing ⚠️
zrml/orderbook/src/weights.rs 0.00% 6 Missing ⚠️
zrml/parimutuel/src/weights.rs 0.00% 6 Missing ⚠️
zrml/prediction-markets/src/weights.rs 95.71% 6 Missing ⚠️
zrml/styx/src/weights.rs 0.00% 4 Missing ⚠️
zrml/neo-swaps/src/weights.rs 93.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   93.25%   93.26%           
=======================================
  Files         133      133           
  Lines       29709    29721   +12     
=======================================
+ Hits        27706    27718   +12     
  Misses       2003     2003           
Flag Coverage Δ
tests 93.26% <79.94%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 27, 2024
@mergify mergify bot merged commit 6868482 into main Aug 27, 2024
42 of 43 checks passed
@mergify mergify bot deleted the release-v0.5.4 branch August 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants