Remove toolchain: input so that rust-toolchain file will be used #823
Conversation
There was a problem hiding this comment.
Ok, the "rustup show" looks like a dirty hot fix 😂. As I understand https://github.com/marketplace/actions/rust-toolchain#the-toolchain-file correctly, they just say, that the toolchain input can be removed to use this file.
In these cases the toolchain can be named in the project's directory in a file called rust-toolchain.toml or rust-toolchain.
When leaving out toolchain in the workflow files doesn't work, maybe rename the root file to rust-toolchain.toml and try again.
Not sure why that will work? I see moonbeam also using the hack "rustup show" https://github.com/PureStake/moonbeam/blob/master/.github/workflows/build.yml |
|
Ok, so you tried it without the toolchain input? I just thought: Why shouldn't it work, when |
|
I researched a little bit and found this issue comment actions-rs/toolchain#126 (comment) . So yeah, sounds like this hack is used at the moment. |
|
I don't get it. You provide this link: https://github.com/marketplace/actions/rust-toolchain#the-toolchain-file. Why use this workaround? |
It does not work as advertise for now, there is a bug and not fixed yet. |
|
This issue? actions-rs/toolchain#126 |
Yes it seems so, here is relevant PR actions-rs/toolchain#166 |
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
.github/workflows/benchmark.yml
Outdated
| # TODO(#XXX): `rustup show` installs the rustc version specified in the `rust-toolchain` file | ||
| # according to https://rust-lang.github.io/rustup/overrides.html. We don't use actions-rs due to the | ||
| # lack of support of `rust-toolchain` files with TOML syntax: | ||
| # https://github.com/actions-rs/toolchain/issues/126. |
There was a problem hiding this comment.
Can you please fill in the XXX with the issue for this, and add this to the other two places where these changes are made? Oh, also I forgot to add indentation to the comment.
| # TODO(#XXX): `rustup show` installs the rustc version specified in the `rust-toolchain` file | |
| # according to https://rust-lang.github.io/rustup/overrides.html. We don't use actions-rs due to the | |
| # lack of support of `rust-toolchain` files with TOML syntax: | |
| # https://github.com/actions-rs/toolchain/issues/126. | |
| # TODO(#XXX): `rustup show` installs the rustc version specified in the `rust-toolchain` file | |
| # according to https://rust-lang.github.io/rustup/overrides.html. We don't use actions-rs due | |
| # to the lack of support of `rust-toolchain` files with TOML syntax: | |
| # https://github.com/actions-rs/toolchain/issues/126. |
There was a problem hiding this comment.
Oh I missed that 😓
There was a problem hiding this comment.
Should we create issue on our git repo?
There was a problem hiding this comment.
No worries. Yeah, let's open a GitHub issue just so we don't forget about removing the workaround when we get the chance.
Chralt98
added
s:accepted
As per https://github.com/marketplace/actions/rust-toolchain#the-toolchain-file
May close #780
As per discussion on https://lightrun.com/answers/actions-rs-toolchain-support-new-toml-format-for-rust-toolchain currently actions-rs has some issues using toolchain files. So used suggested solution there.