Rollup bindings #35
Closed
Rollup bindings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinOndejka
pushed a commit
that referenced
this pull request
Jul 17, 2023
MartinOndejka
force-pushed
the
bindings-berkeley
branch
from
ecf79a0
to
b42f13f
Compare
Closed
MartinOndejka
force-pushed
the
rollup-bindings
branch
2 times, most recently
from
ac65068
to
cfc3fe3
Compare
L-as
commented
Oct 4, 2023
| @@ -79,7 +78,7 @@ module Step = Pickles.Impls.Step | |||
|
|
|||
| let rollup = | |||
| object%js | |||
| method compile = | |||
| method compile (pk : S.Public_key.Compressed.t) = | |||
There was a problem hiding this comment.
This means you have to recompile every time you change the pk. Do note compilation will be cached in the future. It will also cause issues when we try to do a rollup inside a rollup.
L-as
commented
Oct 13, 2023
| @@ Js.to_string txn_snark | ||
| in | ||
| let statement = Transaction_snark.statement txn_snark in | ||
| let root = statement.target.first_pass_ledger in |
There was a problem hiding this comment.
FIXME: this needs to use second pass ledger
There was a problem hiding this comment.
This is already accounting the fact that we are ignoring second pass ledger here 722f50f
L-as
commented
Oct 13, 2023
| in | ||
| let%bind merged = | ||
| time "Transaction_snark.merge" | ||
| (T.merge prev next ~sok_digest:statement.sok_digest) |
There was a problem hiding this comment.
FIXME: this probably doesn't work with zkapp commands correctly
MartinOndejka
force-pushed
the
rollup-bindings
branch
from
413a002
to
c5a0cc5
Compare
MartinOndejka
changed the base branch from
bindings-berkeley
to
o1js-bindings-main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.