Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Pane Frames #680

Open
a-kenji opened this issue Aug 31, 2021 · 2 comments
Open

Configure Pane Frames #680

a-kenji opened this issue Aug 31, 2021 · 2 comments
Labels
config Improvements to the configuration system good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed

Comments

@a-kenji
Copy link
Contributor

a-kenji commented Aug 31, 2021

Allow the configuration of pane frames.

For example where or whether to show the scroll indicator. Have some right aligned, some left aligned. Display the information at the bottom of the frames.

The current default configuration could be something akin to this:

pane_frames:
  top:
    left: [title, ]
    right: [scroll, ]
 bottom:
   left: []
   right: []

Allow the configuration of pane frames to depend on the mode they are in.

@a-kenji a-kenji added the config Improvements to the configuration system label Aug 31, 2021
@imsnif imsnif added good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed labels Sep 25, 2021
@oromate
Copy link
Contributor

oromate commented Nov 11, 2021

Hi, I would like to start this issue.

Currently, the configuration of pane frames is global and can only be enabled or disabled by options 'no-pane-frames'. Maintaining this behavior, @a-kenji 's suggestion would also be global and would only affect the title and scroll. I think it's good that we start like this and then we can expand later. Maybe adding custom settings by tabs or affecting plugins too.

What do you think? Any suggestions for a-kenji's template?

@a-kenji
Copy link
Contributor Author

a-kenji commented Nov 11, 2021

@oromate,
that is awesome!

global and would only affect the title and scroll

I agree! Though keeping in mind extensibility for other "providers" would already be good. Something similar to scroll and title.

It is enough if it is a global option for now.

We can think about different extensibility at some point.
I like where you are going with this - I too think it would be awesome to have plugins configure the pane frames themselves, or for example have a callback so that we
know if a certain section is getting a mouse event.

Any suggestions for a-kenji's template?

Of course I am open for more suggestions.
We also want to display a name for a pane, similar to the tabs in the pane frame,
if you keep that in mind while working on this pr, that would be great.
But obviously not a prerequisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Improvements to the configuration system good first issue Good for newcomers hacktoberfest For the hacktoberfest month help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants