feat(ui): round frame corners

[TheLostLambda]

This PR directly replaces #669

Everything now passes around a Style instead of a Palette, letting us add more styling information in the future. For now, it means round corners in themes!

You can now add:

themes:
  default:
    rounded_corners: true

For round corner goodness!

As an important BREAKING CHANGE (needs @a-kenji 's input probably), color palettes need to be specified in a subsection now!

To explain using an example, this old theme...

themes:
  tokyo-night-storm:
    fg: [169,177,214] #A9B1D6
    bg: [36,40,59] #24283B
    gray: [86,95,137] #565F89
    black: [65,72,104] #414868
    red: [247,118,142] #F7768E
    green: [158,206,106]  #9ECE6A
    yellow: [224,175,104] #E0AF68
    blue: [122,162,247]  #7AA2F7
    magenta: [187,154,247] #BB9AF7
    cyan: [42,195,222] #2AC3DE
    white: [192,202,245] #C0CAF5
    orange: [255,158,100] #FF9E64

Would become:

themes:
  tokyo-night-storm:
    palette:
      fg: [169,177,214] #A9B1D6
      bg: [36,40,59] #24283B
      gray: [86,95,137] #565F89
      black: [65,72,104] #414868
      red: [247,118,142] #F7768E
      green: [158,206,106]  #9ECE6A
      yellow: [224,175,104] #E0AF68
      blue: [122,162,247]  #7AA2F7
      magenta: [187,154,247] #BB9AF7
      cyan: [42,195,222] #2AC3DE
      white: [192,202,245] #C0CAF5
      orange: [255,158,100] #FF9E64

With the optional corner parameter:

themes:
  tokyo-night-storm:
    rounded_corners: true
    palette:
      fg: [169,177,214] #A9B1D6
      bg: [36,40,59] #24283B
      gray: [86,95,137] #565F89
      black: [65,72,104] #414868
      red: [247,118,142] #F7768E
      green: [158,206,106]  #9ECE6A
      yellow: [224,175,104] #E0AF68
      blue: [122,162,247]  #7AA2F7
      magenta: [187,154,247] #BB9AF7
      cyan: [42,195,222] #2AC3DE
      white: [192,202,245] #C0CAF5
      orange: [255,158,100] #FF9E64

[a-kenji]

Yay. This is amazing!

I do think the configuration should be:

pane_frames:
    rounded_corners: true

so we can build upon that and go with something like #680:

pane_frames:
  rounded_corners: true
  top:
    left: [title, ]
    right: [scroll, ]
  bottom:
    left: []
    right: []

[TheLostLambda]

Yay. This is amazing!

I do think the configuration should be:

pane_frames:
    rounded_corners: true

so we can build upon that and go with something like #680:

pane_frames:
  rounded_corners: true
  top:
    left: [title, ]
    right: [scroll, ]
  bottom:
    left: []
    right: []

A good idea! Just to clarify, is the pane_frames nested in the themes part of the config still?

[a-kenji]

That is a good question, I would say no, since it should mostly handle functionality.
And if someone wanted to load a specific theme / pane_frame combination, they could always load a layout.

[TheLostLambda]

Okay, I can do that! Just making sure you'd like to add that to this main config? It feels a little bit like the sort of thing that would belong in a theme and pane_frames feels a bit niche for the top-level, but if you don't think things like the title and scroll should be in a theme, then that's alright and we should keep pane things together.

[a-kenji]

You are right, it does feel out of place in the main config. But I do think it seems very unwieldy under the theme section. Since you would need to configure it for every color scheme separately. Maybe put it under something like ui ?

[TheLostLambda]

You are right, it does feel out of place in the main config. But I do think it seems very unwieldy under the theme section. Since you would need to configure it for every color scheme separately. Maybe put it under something like ui ?

I'd be happy with that, something like ui -> pane_frames -> rounded_corners then?

[a-kenji]

Yes, that sounds very good!

[TheLostLambda]

Hopefully I'll wrap up this PR – got caught up with loads of merge and cleanup work tonight!

[TheLostLambda]

@a-kenji Took me long enough... This should be ready for final review!

[TheLostLambda]

Oh, and for clarity, the config option is now:

ui:
    pane_frames:
        rounded_corners: true

[a-kenji]

LGMT, thank you! This is awesome.

I personally would call it round_corners instead of rounded_corners,
but I am not a native speaker.

[TheLostLambda]

I might stick with rounded corners for now, but they do seem pretty interchangeable nowadays!

[imsnif]

Do we want to add docs for this?