Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working directory inheritence isn't quite working #727

Closed
spacemaison opened this issue Sep 15, 2021 · 0 comments · Fixed by #729
Closed

Working directory inheritence isn't quite working #727

spacemaison opened this issue Sep 15, 2021 · 0 comments · Fixed by #729

Comments

@spacemaison
Copy link
Contributor

I just noticed that when switching between tabs and then splitting into a new pane the current working directory is inherited from the previous tabs pane and not the pane that's focused after switching tabs. This is likely a because we're not updating the pty's active pane when switching between tabs. I will look into why this is happening later tonight and file a PR to fix it.
spacemaison pushed a commit to spacemaison/zellij that referenced this issue Sep 16, 2021
fix(cwd-pane): Fix for cwd not being inherited when switching tabs
a2d78e8 
fixes zellij-org#727

Inheriting the current working directory didn't work when switching
between tabs. This happened because the event to notify the pty of an
pane change was triggered when setting the active pane inside of the
current tab, but switching between tabs will only cause a re-render of
the newly selected tab and it's panes without setting the active pane.
This was fixed by moving the event to notify the pty of the pane change
into the tabs render method.
@spacemaison spacemaison mentioned this issue Sep 16, 2021
Merged
imsnif pushed a commit that referenced this issue Sep 17, 2021
@spacemaison
fix(cwd-pane): Fix for cwd not being inherited when switching tabs (#729
40e74d5 
)

fixes #727

Inheriting the current working directory didn't work when switching
between tabs. This happened because the event to notify the pty of an
pane change was triggered when setting the active pane inside of the
current tab, but switching between tabs will only cause a re-render of
the newly selected tab and it's panes without setting the active pane.
This was fixed by moving the event to notify the pty of the pane change
into the tabs render method.

Co-authored-by: Jesse Tuchsen <not@disclosing>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cwd-pane): Fix for cwd not being inherited when switching tabs spacemaison/zellij
1 participant
@spacemaison