Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-page scroll actions #794

Closed
tailhook opened this issue Oct 20, 2021 · 5 comments
Closed

Half-page scroll actions #794

tailhook opened this issue Oct 20, 2021 · 5 comments
Labels
action Issues related to actions good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tailhook
Copy link

I would like to propose adding half-page scroll actions. In less they are bound to Ctrl+u/Ctrl+d shortcuts. I think these shortcuts can also be used in scroll mode, but at least actions will be useful (if shortcuts are occupied by something).

It's important because it allows to keep track of what is going on when scrolling (i.e. eyes can match half-screen text shifted, and it's easier to find out if something you're looking for would be on the edge of the screen if scrolling by page). Line-wise scrolling is too slow. Alternative might be something like "scroll up 10 lines" (with configurable number of lines), but usually half-page serves as a good number.

@imsnif
Copy link
Member

imsnif commented Oct 20, 2021

I'd also very much like to have this feature. Would you be interested in working on it?

@a-kenji a-kenji added the action Issues related to actions label Oct 20, 2021
@tailhook
Copy link
Author

Not sure I have time spot to look at it soon.

@imsnif imsnif added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 25, 2021
@oromate
Copy link
Contributor

oromate commented Oct 28, 2021

Hi, I would like to start this task. I thought of scrolling half a page with 'u'/'d' in scroll mode

@imsnif
Copy link
Member

imsnif commented Oct 28, 2021

Sounds great @oromate ! Please reach out if you have any questions (here or on Discord, as you prefer)

imsnif added a commit that referenced this issue Nov 8, 2021
* Half-page scroll actions #794

* fix(performance): do not hang when resizing large line wraps (#814)

* fix(performance): do not hang when resizing large line wraps

* style(fmt): make rustfmt happy

* style(clippy): make clippy happy

* docs(changelog): scroll fix

* fix(compatibility): home and end key fix (#815)

* fix(compatibility): handle home/end keys properly from terminfo

* style(fmt): make rustfmt happy

* style(fmt): remove unused import

* docs(changelog): home end key fix

* docs(changelog): fix link

* fix(typo): Correct typo from `occured` to `occurred` (#821)

* docs(changelog): fix a typo

* fix(docs): fix wrong arguments for `cargo make run` given in CONTRIBUTING.md (#819)

* docs(changelog): update `cargo-make` for `v0.35.3`

* fix(warning): Fix an unused import warning of std::fs on macos (#820)

* docs(changelog): fix unused import on darwin

* add: `WriteChars` action (#825)

* Behaves like the `Write` action, but one can specify
  strings themselves instead of their bytecodes.

  Usage:

  WriteChars: "cargo make test",

* docs(changelog): Add `WriteChars` action

* fix(docs): Fix a typo and some grammatical errors in bug_report.md (#826)

* docs(changelog): fix typo bug_report template

* add: `rust-version` (msrv) field to `Cargo.toml` (#828)

* specifies the minimum version the package can be compiled with,
  may be ignored with `--ignore-rust-version` option

  ref: https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-rust-version-field

* docs(changelog): add `rust-version` to `Cargo.toml`

* fix(unix): forkpty => openpty (#830)

* fix(unix): forkpty => openpty

* style(fmt): make rustfmt happy

* docs(changelog): forkpty => openpty

* Fix: move `colors_transform` to `colorsys` (#832)

* `colors_transform` is deprecated and superceded by `colorsys`

  ref: https://crates.io/crates/colors-transform

* docs(changelog): `colors_transform` to `colorsys`

* feat(ui): add right-click support to plugins

* chore(docs): update changelog

* chore(warnings): remove unused imports (#833)

* rename var sroll_rows and review snapshots

* style(fmt): make rustfmt happy

Co-authored-by: Aram Drevekenin <aram@poor.dev>
Co-authored-by: Ken Matsui <26405363+ken-matsui@users.noreply.github.com>
Co-authored-by: a-kenji <aks.kenji@protonmail.com>
Co-authored-by: Tw <tw19881113@gmail.com>
Co-authored-by: Brooks Rady <b.j.rady@gmail.com>
@a-kenji
Copy link
Contributor

a-kenji commented Nov 8, 2021

This is now in v20.0, thanks @oromate.

@a-kenji a-kenji closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action Issues related to actions good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants