Add #[allow(dead_code)] attribute to unused variables
#1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I totally missed that this PR already exists :/ |
|
Never mind :) |
|
In my opinion, removing the code looks better than putting a Perhaps, these variables are currently unused, but they need to be verified once more. |
|
Thanks for your opinion. I close this PR, so any changes should be continued on #1087. |
ken-matsui
deleted the
add-allow-deadcode-attribute-to-unused-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would suggest deleting these variables unless you think they will be used.
If you would so, I would be pleased to remove them in this PR.