fix(compatibility): replace wide characters under cursor properly #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1117 (among other things)
The issue above had to do with wide characters overflowing a cached-render. Meaning we would be doing needless extra padding (since we weren't checking for wide characters in that specific case) and not rendering the frame above the padding (since we'd already rendered it before and thought it was unchanged). This fixes it by making the padding wide-character aware.
This fix also includes better wide-character handling when replacing characters under the cursor. Better handling cases where we replace a wide-character with a non-wide-character and vice-versa.