Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feat): disable_automatic_asset_installation #1226

Merged

Commits on Mar 16, 2022

  1. fix(feat): disable_automatic_asset_installation

    This fixes a regression in the feature system:
    The asset installation didn't get turned off by the feature.
    
    Add error logging to the install functions.
    
    Properly show features in setup
    
    * fix(feat): disable `mkdir` in wasm_wm
    
    The `wasm_vm` creates the `plugin_dir` before mounting it.
    Turn that behavior off on `feature-disable-asset-installation`.
    
    Alternative:
        Is this even needed? We make sure the directory is there upon the
        normal asset installation.
    
    fixes zellij-org#1130
    a-kenji committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    22cff54 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Configuration menu
    Copy the full SHA
    e4cc8bc View commit details
    Browse the repository at this point in the history
  2. fix(feat): disable mkdir in wasm_vm

    disable `mkdir` in `wasm_vm` on `feature-disable-asset-installation`
    a-kenji committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    f820a8f View commit details
    Browse the repository at this point in the history