fix paste freeze (#1366) #1383
Merged
fix paste freeze (#1366) #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that the deadlock is not happening with this PR, good work! |
imsnif
requested changes
May 13, 2022
There was a problem hiding this comment.
Hey @tlinford - thanks for the great troubleshooting on this!
I left some comments, mostly stylistic but I'm also unsure why we increased the channel bound by so much. I haven't tested this yet because I wanted to sort through that issue first. Once we do, I'll give this a thorough hammering and we'll make sure it's all good.
|
@imsnif cleaned it up, should be good for testing. |
|
Seems to work for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1366 by offloading writes to a separate thread.