feat(#195): display current path in the strider #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: zellij-org#195 Display current path on top of the directory files in the strider default plugin. As of now, no configuration is available for this feature.
tlinford
requested changes
Aug 20, 2022
Co-authored-by: Thomas Linford <tlinford@users.noreply.github.com>
tlinford
approved these changes
Aug 23, 2022
tlinford
requested changes
Aug 23, 2022
Comment on lines
+83
to
+84
| let current_path = name.clone(); | ||
| FsEntry::display_with_shortened_name_start(current_path, width) |
There was a problem hiding this comment.
should just return empty string? just did another run and i'm seeing extra output on the right
There was a problem hiding this comment.
oh, thanks for pointing this out. I will check this today in the evening.
|
Hey, what's the status here? |
|
Want to echo @imsnif , what's the status on this? This is an important feature that makes the file tree more useful, unless there's another way to switch dir within the strider window. |
|
Looks like this PR can be closed, as it's functionality has been implemented in #3200. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the #195 issue and resolves the problem of @RobWalt's solution with clicks 1-row offset.
As in Rob's PR, the path displayed is a relative path from the
zellij's start location.Display the current path on top of the directory files in the strider default plugin. As of now, no configuration
is available for this feature.
Examples of how it looks: