Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugins): fix plugin loading data flow #1995

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Dec 6, 2022

This changes the way plugins are loaded on startup and when opening a new tab with a layout.

Up until now the plugin loading blocked the Screen thread (that loaded them) for each plugin. After this change, the plugins are loaded separately in the plugin thread before the reach the screen thread.

The new flow:

  1. server router
  2. plugin thread => loads the plugins and forwards their IDs
  3. pty thread => loads the terminals and forwards their IDs
  4. screen thread => populates the layouts with the above IDs and renders the screen

@imsnif imsnif temporarily deployed to cachix December 6, 2022 13:58 Inactive
@imsnif imsnif merged commit b7adfcc into main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant