Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helix editor (hx) to editors that support prefix positions #2156

Merged
merged 6 commits into from
Feb 18, 2023
Merged

Add Helix editor (hx) to editors that support prefix positions #2156

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4af351
Add Helix editor (`hx`) to editors that support prefix positions
bheylin Feb 12, 2023
9acf464
Add `helix` variant to accepted editors
bheylin Feb 12, 2023
b5f9c37
Add branch for Helix file opening
bheylin Feb 14, 2023
52d93be
Merge branch 'zellij-org:main' into add-helix-to-prefix-pos-list
bheylin Feb 14, 2023
6af43cd
style(code): add clarification comment
imsnif Feb 17, 2023
5951551
style(fmt): whitespace
imsnif Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zellij-server/src/os_input_output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ fn spawn_terminal(
|| command.ends_with("emacs")
|| command.ends_with("nano")
|| command.ends_with("kak")
|| command.ends_with("hx")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add helix? Some distros use the helix command instead of the hx command e.g. ArchLinux and openSUSE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 9acf464

{
failover_cmd_args = Some(vec![file_to_open.clone()]);
args.push(format!("+{}", line_number));
Expand Down